Update pose version requirement and optimize sum usage in pandas#59
Open
gbeane wants to merge 1 commit into
Open
Update pose version requirement and optimize sum usage in pandas#59gbeane wants to merge 1 commit into
gbeane wants to merge 1 commit into
Conversation
…o work with newer versions of pandas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes two targeted improvements: it updates a regular expression to support newer pose estimation versions and simplifies the aggregation logic in the IoU scan generation function.
Regex and metadata updates:
POSE_REGEX_STRinmetadata.pyto support pose estimation versions 2 through 8, instead of just 2 through 6.Performance aggregation logic:
generate_iou_scanincompare_gt.pyby replacing.apply(np.sum)with.sum(), which is the recommended and more efficient approach for summing grouped DataFrame values.